Skip to content

improvement(slack): channel selector for list canvases#4307

Merged
icecrasher321 merged 1 commit intostagingfrom
feat/slack-channel-listCanvas
Apr 27, 2026
Merged

improvement(slack): channel selector for list canvases#4307
icecrasher321 merged 1 commit intostagingfrom
feat/slack-channel-listCanvas

Conversation

@icecrasher321
Copy link
Copy Markdown
Collaborator

Summary

Reuse channel subblock as other tools do for list canvases

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 27, 2026 7:05pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 27, 2026

PR Summary

Low Risk
Low risk: small Slack block config change that only affects how list_canvases accepts an optional channel filter and removes a now-unused input field.

Overview
Updates the Slack block’s list_canvases UI/params to reuse the existing channel/channel-selector input as an optional channel filter.

Removes the dedicated canvasListChannel field/input and its request parameter mapping, relying solely on the canonical channel value for filtering when provided.

Reviewed by Cursor Bugbot for commit 0407906. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

This PR replaces the dedicated plain-text canvasListChannel input for the list_canvases operation with the shared channel-selector subblock already used by other Slack operations, making the UI consistent. The channel value continues to flow correctly because the shared pre-switch handling at effectiveChannel already sets baseParams.channel for all non-DM operations, so no handler-level change is needed beyond removing the now-redundant explicit assignment.

Confidence Score: 5/5

Safe to merge — clean refactor with no logic regressions.

The change correctly removes list_canvases from the channel-selector exclusion list, marks channel as optional for that operation, and relies on the pre-existing shared effectiveChannel → baseParams.channel path that already handles every non-DM operation. The removed canvasListChannel field and its explicit assignment in the switch case are fully superseded. No other operations are affected.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/slack.ts Removes list_canvases from the channel-selector exclusion list, marks channel as optional (not required) for that operation, drops the dedicated canvasListChannel plain-text field and its handler code, and relies on the existing effectiveChannel → baseParams.channel path instead.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User selects operation: list_canvases] --> B[channel-selector subblock shown\nnot required]
    B --> C{User picks a channel?}
    C -- Yes --> D[channel param populated]
    C -- No --> E[channel param empty]
    D --> F["effectiveChannel = channel.trim()"]
    E --> G["effectiveChannel = ''"]
    F --> H["baseParams.channel = effectiveChannel"]
    G --> I[baseParams.channel not set\noptional filter omitted]
    H --> J[list_canvases switch case\nsets count / page / user / tsFrom / tsTo / teamId]
    I --> J
    J --> K[Slack API call with optional channel filter]
Loading

Reviews (1): Last reviewed commit: "improvement(slack): channel selector for..." | Re-trigger Greptile

@icecrasher321 icecrasher321 merged commit 79ff5d8 into staging Apr 27, 2026
14 checks passed
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0407906. Configure here.

Comment thread apps/sim/blocks/blocks/slack.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant